-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Add fixed # tasks per round. Closes space-meridian/roadmap#82 #385
Conversation
Using live data, this will decrease the job count by a lot. We might want to update the target job volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
Do we need to test this code path?
Yes, please. Otherwise, how can we verify that the algorithm works as intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think the proposed algorithm should work well 👍🏻
I'd like to improve a few minor details, PTAL below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will ship tomorrow |
Closes space-meridian/roadmap#82
Depends on filecoin-station/spark-stats#214
Alternatives considered:
Base task count on measurement count from previous round. This data doesn't exist in spark-stats yet. It should lead to better results though, than the currently used station-id count. @bajtos wdyt? Shall we give this a try and see if it behaves well enough?We went with this alternativeQuestions:
Do we need to test this code path?YesTODO