feat: derive PASSPHRASE for Core from the wallet #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a PASSPHRASE for Station Core to let it encrypt the station identity stored on the filesystem. The passphrase is created by signing a constant message using the private wallet key that's unique to each Station Desktop instance. This way the passphrase is unique, cannot be guessed without the knowledge of the wallet private key, and stays the same accross Station Desktop restarts. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
|
Discussion point: should I write a test for this change? |
juliangruber
approved these changes
Apr 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a PASSPHRASE for Station Core to let it encrypt the station identity stored on the filesystem.
The passphrase is created by signing a constant message using the private wallet key that's unique to each Station Desktop instance. This way the passphrase is unique, cannot be guessed without the knowledge of the wallet private key, and stays the same accross Station Desktop restarts.
/cc @PatrickNercessian
Links: