-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --recreateStationIdOnError
#563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed implementation LGTM.
Let's add some test please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
What do you think about improving the following error message to explain to the user that they can re-run Station Core with the new flag to fix the problem?
Line 64 in fe02c6e
'Cannot decrypt Station ID file. Did you configure the correct PASSPHRASE?', |
Great idea! |
For filecoin-station/desktop#1726
I decided to add this flag instead of a new exit code (as suggested in filecoin-station/desktop#1726 (comment)), because with the new exit code Station Desktop needs to know where Station Core stores its internal files, and this coupling isn't necessary.