Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add restart modules #170

Merged
merged 9 commits into from
Aug 21, 2023
Merged

add restart modules #170

merged 9 commits into from
Aug 21, 2023

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Jun 29, 2023 •
edited
Loading

Alternative implementation to #169.

Notable differences:

Instead of the zinnia lib restarting itself internally, we make zinnia.start() throw an error when it exists. Then, we use p-retry() to take care of restarting it

@juliangruber juliangruber requested a review from bajtos June 29, 2023 09:11
@socket-security
Copy link

socket-security bot commented Jun 29, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
p-retry 5.1.2 None +2 39.5 kB sindresorhus

bajtos
bajtos reviewed Jun 29, 2023
View reviewed changes
commands/station.js Outdated Show resolved Hide resolved
juliangruber
juliangruber commented Jun 29, 2023
View reviewed changes
lib/zinnia.js Outdated Show resolved Hide resolved
@bajtos bajtos mentioned this pull request Jun 29, 2023
Closed
@juliangruber juliangruber changed the title add restart zinnia add restart modules Aug 21, 2023
bajtos
bajtos approved these changes Aug 21, 2023
View reviewed changes
lib/zinnia.js Show resolved Hide resolved
@juliangruber juliangruber enabled auto-merge (squash) August 21, 2023 13:15
@juliangruber juliangruber merged commit 6002287 into main Aug 21, 2023
15 checks passed
@juliangruber juliangruber deleted the add/restart-zinnia branch August 21, 2023 13:21
@bajtos bajtos mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos