Finish logging #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k iterator installs a ipfs-unixfs-exporter fork for DFS traversal
* Record bytes transferred * Record request duration after download finishes or errors * Report verification errors
guanzo
commented
Sep 14, 2023
DiegoRBaquero
approved these changes
Sep 14, 2023
| } | ||
| } catch (err) { | ||
| log.ifNetworkError = err.message |
There was a problem hiding this comment.
what does "if network error" mean here?
There was a problem hiding this comment.
it just means a fetch error occurred because it only throws for network errors. The "if" prefix is a bit wonky but somebody thought it was a better naming scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the js-client ready for production use by the service worker or anyone else.
Logging:
Due to time constraints, I had to fork js-ipfs-unixfs and implement DFS traversal.