Upstream controller don't abort all requests #38
Conversation
| @@ -261,6 +265,13 @@ export class Saturn { | |||
| } | |||
|
|
|||
| const fetchContent = async function * () { | |||
| const controller = new AbortController(); | |||
There was a problem hiding this comment.
This is nonblocking but I would add this in the fetchCid function instead.
There was a problem hiding this comment.
This special handling of the controller is specific to the fallback one (where there are 5 retries), the fetchCid function should use the one passed by the caller. Can you expand on your thoughts?
|
@DiegoRBaquero LGTM. @DiegoRBaquero just confirming the intended behaviour here. If the client utilizing this module aborts, that would disable any fallback functionality from occurring. Also pointing out that we still don't have proper uptstream controller handling for race requests in the js client. |
Correct
I can also add the functionality to racing, which will be different than fallback's |
When there's an upstream controller passed, don't use it as the one passed to each request, but rather proxy the abort to current one only. Also, if upstream controller was aborted, don't try yielding next fallback