Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error handling on shim #527

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix: improve error handling on shim #527

merged 1 commit into from
Feb 1, 2024

Conversation

DiegoRBaquero
Copy link
Collaborator

No description provided.

joaosa
joaosa reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@joaosa joaosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to reduce the reported errors on Sentry?

@DiegoRBaquero
Copy link
Collaborator Author

Is this to reduce the reported errors on Sentry?

Yes, because Sentry captures unhandled exceptions and rejections, and because this is the entry point, these were considered unhandled

@DiegoRBaquero DiegoRBaquero merged commit b9ad8e8 into main Feb 1, 2024
4 of 5 checks passed
@DiegoRBaquero DiegoRBaquero deleted the errors branch February 1, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaosa joaosa joaosa approved these changes

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

@guanzo guanzo Awaiting requested review from guanzo

@AmeanAsad AmeanAsad Awaiting requested review from AmeanAsad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiegoRBaquero @joaosa