Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix: use unix signal handlers instead of Mach ports #2042

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Stebalien
Copy link
Member

This will apparently interfere with some debugging tools, but we ran into an issue where Mach ports weren't always catching illegal instruction signals form wasmtime (affecting macos only).

This will apparently interfere with some debugging tools, but we ran
into an issue where Mach ports weren't always catching illegal
instruction signals form wasmtime (affecting macos only).
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.93%. Comparing base (4777600) to head (54b2e60).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/v2    #2042      +/-   ##
==============================================
+ Coverage       31.86%   37.93%   +6.06%     
==============================================
  Files              83       43      -40     
  Lines            6459     1827    -4632     
==============================================
- Hits             2058      693    -1365     
+ Misses           4401     1134    -3267     

see 46 files with indirect coverage changes

@Stebalien Stebalien merged commit 9213fcf into release/v2 Sep 12, 2024
7 checks passed
@Stebalien Stebalien deleted the steb/disable-mach-ports-v2 branch September 12, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants