Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shared: check bls zero address without lazy_static #1984

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Stebalien
Copy link
Member

Trying to clean up this module a bit. I'll remove the other uses of lazy_static in a future (significantly more breaking) change.

@Stebalien Stebalien requested a review from rvagg February 9, 2024 04:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (12cfcc7) 75.53% compared to head (052e1d2) 75.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1984      +/-   ##
==========================================
- Coverage   75.53%   75.52%   -0.01%     
==========================================
  Files         158      158              
  Lines       15600    15600              
==========================================
- Hits        11783    11782       -1     
- Misses       3817     3818       +1     
Files Coverage Δ
shared/src/address/mod.rs 92.72% <0.00%> (ø)

... and 2 files with indirect coverage changes

Trying to clean up this module a bit. I'll remove the other uses of
lazy_static in a future (significantly more breaking) change.
@Stebalien Stebalien force-pushed the steb/remove-address-lazystatic branch from 592d8ae to 052e1d2 Compare February 9, 2024 05:01
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly amusing that it's that simple; I had to check it myself to see

@Stebalien Stebalien merged commit 5cd204d into master Feb 9, 2024
14 checks passed
@Stebalien Stebalien deleted the steb/remove-address-lazystatic branch February 9, 2024 16:37
@Stebalien
Copy link
Member Author

Yeah, I was kind of surprised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants