Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert backtrace frame from entrypoint to method #1956

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Stebalien
Copy link
Member

This is a pretty public API (information gets displayed to the user) and I'd rather not go about changing it at the moment. We'll probably bring this back eventually, but I'm trying to cut a release and integrate with the FFI with minimal outward-facing changes.

This is a pretty public API (information gets displayed to the user) and
I'd rather not go about changing it at the moment. We'll probably bring
this back eventually, but I'm trying to cut a release and integrate with
the FFI with minimal outward-facing changes.
@Stebalien
Copy link
Member Author

We'll probably bring this back eventually

Also, when we do that, I expect we'll change the Frame to make more sense in this case in this case, maybe? Maybe even include the code CID?

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Merging #1956 (ea0319d) into master (6722164) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
- Coverage   75.78%   75.77%   -0.01%     
==========================================
  Files         157      157              
  Lines       15447    15449       +2     
==========================================
  Hits        11706    11706              
- Misses       3741     3743       +2     
Files Coverage Δ
fvm/src/call_manager/backtrace.rs 84.05% <100.00%> (ø)
fvm/src/call_manager/default.rs 89.92% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

@Stebalien
Copy link
Member Author

Merging now so I can start cutting releases.

@Stebalien Stebalien merged commit 7ae3403 into master Dec 15, 2023
12 checks passed
@Stebalien Stebalien deleted the steb/revert-backtrace-frame-change branch December 15, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants