-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dependencies into workspace #1955
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
- Coverage 75.79% 75.59% -0.20%
==========================================
Files 157 157
Lines 15441 15490 +49
==========================================
+ Hits 11703 11710 +7
- Misses 3738 3780 +42 |
0800404
to
92c0582
Compare
also needed to rename kamt/fuzz/simple and hamt/fuzz/simple targets as they were colliding using a single workspace
92c0582
to
473d61c
Compare
[workspace] | ||
members = ["."] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.... I think this may have been why we didn't include this in the workspace. We need to check the cargo tree
(and enabled features) in the workspace itself to make sure we're not "unifying" them. I'll go ahead and do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, look up "feature unification in rust" if you want to have bad dreams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Actually... this seems fine? I thought I saw the arbitrary feature/crates getting included in the main dependency tree... but now I'm not seeing that.
Ok, so, I think this actually works. But is there any reason not to migrate the rest of the deps (e.g., Are we just moving "shared" deps? |
Yeah, I skipped moving dependencies that only were used in one crate into the root workspace |
This enables us to remove the parent crate that the fuzz crates require (#421)
This PR moves all dependencies and metadata (version, license, etc) to the root workspace so that we can manage them in a central place.