refactor: simplify the DefaultFilecoinKernel generics #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1943 +/- ##
==========================================
+ Coverage 75.68% 75.71% +0.02%
==========================================
Files 157 157
Lines 15478 15479 +1
==========================================
+ Hits 11715 11720 +5
+ Misses 3763 3759 -4
|
Stebalien
force-pushed
the
refactor/simple-filecoin-kernel
branch
from
f1e1614
to
ac46bb6
Compare
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
949df99
to
0904fdf
Compare
Stebalien
force-pushed
the
refactor/simple-filecoin-kernel
branch
from
ac46bb6
to
612516d
Compare
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
0904fdf
to
1eb51dd
Compare
Stebalien
force-pushed
the
refactor/simple-filecoin-kernel
branch
from
612516d
to
f6f0921
Compare
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
1eb51dd
to
3abd811
Compare
Stebalien
force-pushed
the
refactor/simple-filecoin-kernel
branch
from
f6f0921
to
e95e412
Compare
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
3abd811
to
bae4c9f
Compare
It's not _actually_ generic over the inner kernel type (only works for
the `DefaultKernel`), so we might as well simplify that.
I.e., was:
DefaultFilecoinKernel<DefaultKernel<impl CallManager>>
Now:
DefaultFilecoinKernel<impl CallManager>
Stebalien
force-pushed
the
refactor/simple-filecoin-kernel
branch
from
e95e412
to
d1696f0
Compare
|
I'm just going to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not actually generic over the inner kernel type (only works for
the
DefaultKernel), so we might as well simplify that.I.e., was:
Now: