refactor: make bind_syscalls an associated function
#1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
+ Coverage 75.68% 75.73% +0.05%
==========================================
Files 157 157
Lines 15483 15478 -5
==========================================
+ Hits 11718 11722 +4
+ Misses 3765 3756 -9
|
Stebalien
force-pushed
the
feat/narrow-trait-req
branch
from
8d1a723
to
645c625
Compare
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
949df99
to
0904fdf
Compare
Stebalien
force-pushed
the
feat/narrow-trait-req
branch
from
645c625
to
b95f44b
Compare
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
0904fdf
to
1eb51dd
Compare
Stebalien
force-pushed
the
feat/narrow-trait-req
branch
from
b95f44b
to
26f124d
Compare
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
1eb51dd
to
3abd811
Compare
Stebalien
force-pushed
the
feat/narrow-trait-req
branch
from
26f124d
to
3d5571d
Compare
The result of this function is cached and not tied to any given kernel. It shouldn't have access to a particular kernel's state because the "result" of calling this function will be used with multiple kernels (of the same type).
Stebalien
force-pushed
the
feat/static-bind-syscalls
branch
from
3abd811
to
bae4c9f
Compare
maciejwitowski
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of this function is cached and not tied to any given kernel. It shouldn't have access to a particular kernel's state because the "result" of calling this function will be used with multiple kernels (of the same type).