-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make partial kernels possible #1941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
- Coverage 75.70% 75.68% -0.02%
==========================================
Files 157 157
Lines 15473 15483 +10
==========================================
+ Hits 11714 11719 +5
- Misses 3759 3764 +5
|
Stebalien
force-pushed
the
fix/delegate-with-prelude
branch
from
December 8, 2023 02:51
f0f7e9a
to
4f28aff
Compare
Stebalien
force-pushed
the
feat/narrow-trait-req
branch
2 times, most recently
from
December 8, 2023 08:37
645c625
to
b95f44b
Compare
maciejwitowski
approved these changes
Dec 8, 2023
maciejwitowski
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are all compiler-checked so I'm happy to approve them.
Stebalien
force-pushed
the
feat/narrow-trait-req
branch
from
December 9, 2023 14:12
b95f44b
to
26f124d
Compare
This brings us one step closer to making the syscalls more configurable.
This makes the kernel more customizable as it no longer "assumes" that all of these operations will be available. Also, remove the `LimiterOps` trait entirely, this isn't actually an "op" (i.e., not a user-invokable operation). The gas ops will get moved around in a future commit as many of them aren't really "ops" either.
Stebalien
force-pushed
the
feat/narrow-trait-req
branch
from
December 10, 2023 01:37
26f124d
to
3d5571d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has two parts:
This should make it possible to implement custom kernels that expose fewer operations.
It also removes the
LimiterOps
trait as that's not really an "op".