-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add nv22 skeleton #1929
feat: Add nv22 skeleton #1929
Conversation
Addition of Network Version 22 skeleton
@Stebalien @fridrik01 do we need to add a nv22-dev feature in cargo.toml have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting as long as test failures are addressed before merging.
EDIT: Also added some additional comments since I reviewed this originally quite late
Could you please advise on this? (I noticed we do this in previous ones, assuming it’s for avoiding unintended potential consensus breaking change? |
I don't know if its strictly necessary but given that @Stebalien is out, then it would be the safe option here, so I would vote yes. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
+ Coverage 75.59% 75.71% +0.12%
==========================================
Files 153 157 +4
Lines 15118 15477 +359
==========================================
+ Hits 11428 11718 +290
- Misses 3690 3759 +69
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add nv22-dev
as a feature in fvm/Cargo.toml
(see here for example)
Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit, but LGTM with that.
* [WIP] feat: Add nv22 skeleton Addition of Network Version 22 skeleton * Update mod.rs * Update default.rs * Update mod.rs * Update fvm/src/gas/price_list.rs Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com> * Update nv21-dev to nv22-dev * Add nv22-dev to Cargo.toml * Fix formatting issue * Update fvm/src/gas/price_list.rs --------- Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
Addition of Network Version 22 skeleton