feat: make it possible to construct a GasDuration #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us construct "gas charge" objects with constant times (for tracing). - Use an explicit enum with 3 options to avoid allocating/using an Arc+OnceCell when we don't need it. - Implement Debug manually to hide implementation details. - Change the assertion inside `GasTimer::new` to "debug only". If someone passes a "filled" duration, treat the gas timer as a no-op.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
- Coverage 75.55% 75.54% -0.02%
==========================================
Files 152 152
Lines 15106 15119 +13
==========================================
+ Hits 11414 11422 +8
- Misses 3692 3697 +5
|
LesnyRumcajs
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us construct "gas charge" objects with constant times (for tracing). We primarily need this to convert between different gas duration type versions.
GasTimer::newto "debug only". If someone passes a "filled" duration, treat the gas timer as a no-op.