feat: cleanup event error cases #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Sep 14, 2023
Stebalien
commented
- Fail with LimitExceeded where it makes sense.
- Validate that we comsume all keys/values.
|
Implements filecoin-project/FIPs#831 |
Stebalien
force-pushed
the
steb/event-length-checks
branch
from
eecd51e
to
4fe8df4
Compare
|
Builds on #1885 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1886 +/- ##
=======================================
Coverage ? 75.58%
=======================================
Files ? 152
Lines ? 14939
Branches ? 0
=======================================
Hits ? 11292
Misses ? 3647
Partials ? 0 |
fridrik01
reviewed
Sep 15, 2023
| if header.key_len > MAX_KEY_LEN as u32 { | ||
| let tmp = header.key_len; | ||
| return Err(syscall_error!(IllegalArgument; "event key exceeded max size: {} > {MAX_KEY_LEN}", tmp).into()); | ||
| return Err(syscall_error!(LimitExceeded; "event key exceeded max size: {} > {MAX_KEY_LEN}", tmp).into()); |
There was a problem hiding this comment.
nit, but in filecoin-project/FIPs#831 it lists that we check each entry key individually for valid UTF8 while in our impl we do it all upfront for all keys.
There was a problem hiding this comment.
Gah, my patch reverts my previous fixes.
1. Fail with LimitExceeded where it makes sense. 2. Validate that we comsume all keys/values.
Stebalien
force-pushed
the
steb/event-length-checks
branch
from
4fe8df4
to
29aac0b
Compare
Stebalien
added a commit
that referenced
this pull request
Sep 21, 2023
1. Fail with LimitExceeded where it makes sense. 2. Validate that we comsume all keys/values.
Stebalien
added a commit
that referenced
this pull request
Sep 21, 2023
1. Fail with LimitExceeded where it makes sense. 2. Validate that we comsume all keys/values.
Stebalien
added a commit
that referenced
this pull request
Sep 21, 2023
1. Fail with LimitExceeded where it makes sense. 2. Validate that we comsume all keys/values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.