chore: deprecate default bitwidths in the KAMT/AMT #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We don't intentionally use these anywhere. 2. We _do_ unintentionally use these where we shouldn't (filecoin-project/builtin-actors#1346). fixes #1828
Stebalien
force-pushed
the
chore/deprecate-default-bit-widths
branch
from
ea6b1ac
to
f42072d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1831 +/- ##
===========================================
- Coverage 75.29% 56.44% -18.85%
===========================================
Files 149 149
Lines 14575 14577 +2
===========================================
- Hits 10974 8228 -2746
- Misses 3601 6349 +2748
|
anorth
approved these changes
Aug 3, 2023
ipld/kamt/benches/kamt_benchmark.rs
Outdated
| @@ -56,7 +62,7 @@ fn insert(c: &mut Criterion) { | |||
| c.bench_function("KAMT bulk insert (no flush)", |b| { | |||
| b.iter(|| { | |||
| let db = fvm_ipld_blockstore::MemoryBlockstore::default(); | |||
| let mut a = BKamt::new(&db); | |||
| let mut a = BKamt::new_with_config(&db, Config::default()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1828