feat: add new fields to message trace for supporting new trace api #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
+ Coverage 75.21% 75.22% +0.01%
==========================================
Files 149 149
Lines 14592 14600 +8
==========================================
+ Hits 10975 10983 +8
Misses 3617 3617
|
fridrik01
requested review from
a team and
Stebalien
and removed request for
a team
Stebalien
reviewed
Jul 27, 2023
fridrik01
force-pushed
the
traceapi-new-fields
branch
from
0f08bde
to
9e16205
Compare
fridrik01
changed the title
7 tasks
anorth
reviewed
Jul 30, 2023
fridrik01
force-pushed
the
traceapi-new-fields
branch
from
a515dd2
to
8a00486
Compare
arajasek
approved these changes
Aug 21, 2023
Stebalien
approved these changes
Aug 21, 2023
Stebalien
requested changes
Aug 21, 2023
Stebalien
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1793 and https://github.com/filecoin-project/fvm-pm/issues/613
This PR adds the following fields to
ExecutionEventwhich are required to confirm to the trace api spec:gas_limit: The gas provided by the senderread_only: Whether the call is read only or not