Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove an unnecessary event copy #1818

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

Stebalien
Copy link
Member

This came up when reviewing the gas costs: we don't need this copy.

@Stebalien Stebalien requested a review from fridrik01 July 19, 2023 21:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #1818 (228837b) into master (124f444) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1818   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files         149      149           
  Lines       14553    14553           
=======================================
  Hits        10962    10962           
  Misses       3591     3591           
Files Changed Coverage Δ
fvm/src/call_manager/default.rs 88.57% <100.00%> (ø)

@Stebalien Stebalien merged commit 949f094 into master Jul 20, 2023
12 checks passed
@Stebalien Stebalien deleted the chore/remove-event-copy branch July 20, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants