feat: allow constructing an AMT from an iterator or borrowed values. #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 51.69% 51.80% +0.10%
==========================================
Files 125 125
Lines 10914 10928 +14
==========================================
+ Hits 5642 5661 +19
+ Misses 5272 5267 -5
|
mriise
approved these changes
Nov 15, 2022
ipld/amt/src/amt.rs
Outdated
| D: fvm_ipld_encoding::serde_bytes::Deserializer<'de>, | ||
| { | ||
| use serde::de::Error; | ||
| Err(D::Error::custom("can't deserialize")) |
There was a problem hiding this comment.
"FakeDeserialize can't be deserialized"
raulk
reviewed
Nov 15, 2022
| /// Generates an AMT with block store and array of cbor marshallable objects and returns Cid | ||
| /// | ||
| /// This can be called with an iterator of _references_ to values to avoid copying. | ||
| pub fn new_from_iter(block_store: BS, vals: impl IntoIterator<Item = V>) -> Result<Cid, Error> { |
There was a problem hiding this comment.
Need the bitwidth here; that's another reason I couldn't use this method. Because event HAMTs are not mutable, I think it makes sense to optimise for lower depth, but curious about your opinion. I think a bitwidth of 5 or 8 makes the most sense here?
There was a problem hiding this comment.
Depends on the max serialized size of an event, really.
This works because we never have to read or deserialize when creating an AMT from scratch.
Stebalien
force-pushed
the
feat/amt-from-iter-borrowed
branch
from
760435b
to
f865fd9
Compare
Stebalien
force-pushed
the
feat/amt-from-iter-borrowed
branch
from
f865fd9
to
aeed415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works because we never have to read or deserialize when creating an AMT from scratch.
Most of the code changes are actually just re-arranging the implementation into three sections:
V: DeserializeOwnedrequirement.