Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI ubuntu-latest - test job sometimes failing test_debug check #1924

Closed
jdjaustin opened this issue Nov 15, 2023 · 1 comment · Fixed by #1926
Closed

CI ubuntu-latest - test job sometimes failing test_debug check #1924

jdjaustin opened this issue Nov 15, 2023 · 1 comment · Fixed by #1926

Comments

@jdjaustin
Copy link
Contributor

This is not a consistent failure, but seems to occur randomly. ubuntu-latest - test job's test_debug check somtimes fails with a mismatched address. See screenshot below:
Screen Shot 2023-11-15 at 12 00 11 PM
@Stebalien
Copy link
Member

Yeah, so, this is due to the set_network test. Unfortunately, rust runs tests in threads not processes.

Stebalien added a commit that referenced this issue Nov 16, 2023
@Stebalien
test: run the address::set_network test in a new process
214e80c 
This prevents it from messing with the other tests.

fixes #1924
@Stebalien Stebalien mentioned this issue Nov 16, 2023
Merged
fridrik01 pushed a commit that referenced this issue Nov 20, 2023
@Stebalien @fridrik01
test: run the address::set_network test in a new process
f631076 
This prevents it from messing with the other tests.

fixes #1924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: run the address::set_network test in a new process filecoin-project/ref-fvm
2 participants
@Stebalien @jdjaustin