Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sectorstorage: Fix manager restart edge-case #4645

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 29, 2020

Fixes an issue where:

  • We were running some task on the worker
  • Manager would restart
  • Worker would deliver the result
  • Manager would start waiting for the result after it was deliver
  • The task would hang ~forever

Made pretty painful by the fact that it's easy to trigger when we're restarting with a worker which is running Commit2 and has sector data on it:

  • Worker is running C2
  • Manager restarts
  • Manager calls C1, hangs because the worker needs to finish C2
  • Worker finishes C2, returns to manager
  • C1 then runs on the worker, returns just fine
  • C2 hangs due to this bug

@magik6k
Copy link
Contributor Author

magik6k commented Oct 29, 2020

(verified to work on real setup with the Commit1/2 scenario)

@magik6k magik6k merged commit dc5d631 into master Oct 29, 2020
@magik6k magik6k deleted the fix/miner-restart-edgecase branch October 29, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants