Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new column for receipt_returns: parsed_return #1247

Closed
Terryhung opened this issue Jul 26, 2023 · 2 comments
Closed

Add new column for receipt_returns: parsed_return #1247

Terryhung opened this issue Jul 26, 2023 · 2 comments
Assignees
@Terryhung
Labels
kind/feature New feature request

Comments

@Terryhung
Copy link
Collaborator

Description

Currently, the task "receipt_return" stores the return data only in bytes. Now, we are planning to store the parsed return data in JSONB format if it is parsable.

Acceptance criteria

  • New column in receipt_returns: parsed_return

Where to begin

  1. make a change: https://github.com/filecoin-project/lily/blob/master/tasks/messages/receiptreturn/task.go
  2. reference: fevm_trace
@Terryhung Terryhung added the kind/feature New feature request label Jul 26, 2023
@Terryhung Terryhung self-assigned this Jul 26, 2023
@Terryhung Terryhung changed the title Add new column for receipt_returns: parsedReturn Add new column for receipt_returns: parsed_return Jul 26, 2023
@birdychang
Copy link
Contributor

I thought we wanna add them to receipts.

@Terryhung
Copy link
Collaborator Author

Good idea, let me change it again.

@Terryhung Terryhung mentioned this issue Jul 27, 2023
Merged
@Terryhung Terryhung reopened this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Terryhung Terryhung

Labels
kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Terryhung @birdychang