Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error recording retrieval failures #364

Closed
kylehuntsman opened this issue Jul 17, 2023 · 0 comments
Closed

Error recording retrieval failures #364

kylehuntsman opened this issue Jul 17, 2023 · 0 comments
Assignees
@rvagg
Labels
bug Something isn't working

Comments

@kylehuntsman
Copy link
Contributor

kylehuntsman commented Jul 17, 2023 •
edited
Loading

I'm now seeing the following error at the end of most of my lassie fetches. Not sure if the error is always related to HTTP or not.

2023-07-17T11:47:49.852-0700    ERROR   lassie/retriever        retriever/parallelpeerretriever.go:356  Error recording retrieval failure for protocol transport-ipfs-gateway-http: internal error, no such active retrieval 3145cc82-5a58-4866-9580-0553ba85effb

Here is one example of the fetch progress logs I was running

$ ./lassie fetch -o - -p bafybeic56z3yccnla3cutmvqsn5zy3g24muupcsjtoyp3pu5pm5amurjx4 | car extract

Fetching bafybeic56z3yccnla3cutmvqsn5zy3g24muupcsjtoyp3pu5pm5amurjx4
Querying indexer for bafybeic56z3yccnla3cutmvqsn5zy3g24muupcsjtoyp3pu5pm5amurjx4...
Found 12 storage provider candidate(s) in the indexer:
        12D3KooWPgBdZSbmKbD7ZQGjU7gZCcCKGvWSnBf1q4xAbpDdtJaJ, Protocols: [transport-ipfs-gateway-http]
        12D3KooWKGCcFVSAUXxe7YP62wiwsBvpCmMomnNauJCA67XbmHYj, Protocols: [transport-graphsync-filecoinv1]
        12D3KooWKGCcFVSAUXxe7YP62wiwsBvpCmMomnNauJCA67XbmHYj, Protocols: [transport-bitswap]
        QmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC, Protocols: [transport-bitswap]
        QmUA9D3H7HeCYsirB3KmPSvZh3dNXMZas6Lwgr4fv1HTTp, Protocols: [transport-ipfs-gateway-http]
        QmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC, Protocols: [transport-bitswap]
        QmUA9D3H7HeCYsirB3KmPSvZh3dNXMZas6Lwgr4fv1HTTp, Protocols: [transport-ipfs-gateway-http]
        12D3KooWJ8YAF6DiRxrzcxoeUVjSANYxyxU55ruFgNvQB4EHibpG, Protocols: [transport-graphsync-filecoinv1]
        12D3KooWJqxfjvbDkKByJQeT5urmeFBavNhNvidsAeqjWr6hf7jT, Protocols: [transport-bitswap]
        12D3KooWDCXxiSsLi1NT9tsiyimwV6YstQkrjTjD2hAkz2KRVAGG, Protocols: [transport-ipfs-gateway-http]
        12D3KooWJWAwD6CbJnDm6tHcFuZxvWrjhp53hDjLHM1GiP1pYXmY, Protocols: [transport-graphsync-filecoinv1]
        12D3KooWJWAwD6CbJnDm6tHcFuZxvWrjhp53hDjLHM1GiP1pYXmY, Protocols: [transport-bitswap]
Retrieving from [Bitswap] (started-retrieval)...
Retrieving from [12D3KooWDCXxiSsLi1NT9tsiyimwV6YstQkrjTjD2hAkz2KRVAGG] (started-retrieval)...
Retrieving from [12D3KooWDCXxiSsLi1NT9tsiyimwV6YstQkrjTjD2hAkz2KRVAGG] (connected-to-provider)...
Retrieving from [12D3KooWJWAwD6CbJnDm6tHcFuZxvWrjhp53hDjLHM1GiP1pYXmY] (started-retrieval)...
Retrieving from [QmUA9D3H7HeCYsirB3KmPSvZh3dNXMZas6Lwgr4fv1HTTp] (started-retrieval)...
Retrieving from [12D3KooWPgBdZSbmKbD7ZQGjU7gZCcCKGvWSnBf1q4xAbpDdtJaJ] (started-retrieval)...
Retrieving from [QmUA9D3H7HeCYsirB3KmPSvZh3dNXMZas6Lwgr4fv1HTTp] (connected-to-provider)...
Retrieving from [12D3KooWKGCcFVSAUXxe7YP62wiwsBvpCmMomnNauJCA67XbmHYj] (started-retrieval)...
Retrieving from [12D3KooWJ8YAF6DiRxrzcxoeUVjSANYxyxU55ruFgNvQB4EHibpG] (started-retrieval)...
Retrieving from [12D3KooWPgBdZSbmKbD7ZQGjU7gZCcCKGvWSnBf1q4xAbpDdtJaJ] (connected-to-provider)...
Retrieving from [12D3KooWJWAwD6CbJnDm6tHcFuZxvWrjhp53hDjLHM1GiP1pYXmY] (connected-to-provider)...
Retrieving from [12D3KooWJWAwD6CbJnDm6tHcFuZxvWrjhp53hDjLHM1GiP1pYXmY] (proposed)...
Retrieving from [12D3KooWJ8YAF6DiRxrzcxoeUVjSANYxyxU55ruFgNvQB4EHibpG] (connected-to-provider)...
Retrieving from [12D3KooWKGCcFVSAUXxe7YP62wiwsBvpCmMomnNauJCA67XbmHYj] (connected-to-provider)...
Retrieving from [Bitswap] (first-byte-received)...
Received 18 blocks / 15 MiB....
Fetched [bafybeic56z3yccnla3cutmvqsn5zy3g24muupcsjtoyp3pu5pm5amurjx4] from []:
        Duration: 7.760195108s
          Blocks: 18
           Bytes: 15 MiB
2023-07-17T11:47:49.852-0700    ERROR   lassie/retriever        retriever/parallelpeerretriever.go:356  Error recording retrieval failure for protocol transport-ipfs-gateway-http: internal error, no such active retrieval 3145cc82-5a58-4866-9580-0553ba85effb
2023-07-17T11:47:49.853-0700    ERROR   lassie/retriever        retriever/parallelpeerretriever.go:356  Error recording retrieval failure for protocol transport-ipfs-gateway-http: internal error, no such active retrieval 3145cc82-5a58-4866-9580-0553ba85effb
2023-07-17T11:47:49.853-0700    ERROR   lassie/retriever        retriever/parallelpeerretriever.go:356  Error recording retrieval failure for protocol transport-ipfs-gateway-http: internal error, no such active retrieval 3145cc82-5a58-4866-9580-0553ba85effb
extracted 1 file(s)

It connects to three HTTP providers, gets it's first byte via Bitswap, and then I get the three errors at the end after successfully retrieving.

  • 12D3KooWDCXxiSsLi1NT9tsiyimwV6YstQkrjTjD2hAkz2KRVAGG
  • QmUA9D3H7HeCYsirB3KmPSvZh3dNXMZas6Lwgr4fv1HTTp
  • 12D3KooWPgBdZSbmKbD7ZQGjU7gZCcCKGvWSnBf1q4xAbpDdtJaJ

It also fails to tell me which provider it successfully fetch from

Fetched [bafybeic56z3yccnla3cutmvqsn5zy3g24muupcsjtoyp3pu5pm5amurjx4] from []:
@kylehuntsman kylehuntsman added the bug Something isn't working label Jul 17, 2023
@rvagg rvagg self-assigned this Jul 18, 2023
rvagg added a commit that referenced this issue Aug 9, 2023
@rvagg
fix: don't record failures on context cancellation
3eaac4e 
Gate the case where the retriever (parent) cancels a protocol retriever because
another has completed successfully. If a retrieval fails in this case, it's not
a failure that we should either report in the event system, or record against
the SP's performance stats.

Fixes: #364

I believe this fixes #364, but it's hard to reproduce reliably so I can't be
sure.
@rvagg rvagg mentioned this issue Aug 9, 2023
Merged
rvagg added a commit that referenced this issue Aug 11, 2023
@rvagg
fix: don't record failures on context cancellation
bada8c5 
Gate the case where the retriever (parent) cancels a protocol retriever because
another has completed successfully. If a retrieval fails in this case, it's not
a failure that we should either report in the event system, or record against
the SP's performance stats.

Fixes: #364

I believe this fixes #364, but it's hard to reproduce reliably so I can't be
sure.
rvagg added a commit that referenced this issue Aug 11, 2023
@rvagg
fix: don't record failures on context cancellation
a3636e0 
Gate the case where the retriever (parent) cancels a protocol retriever because
another has completed successfully. If a retrieval fails in this case, it's not
a failure that we should either report in the event system, or record against
the SP's performance stats.

Fixes: #364

I believe this fixes #364, but it's hard to reproduce reliably so I can't be
sure.
@rvagg rvagg closed this as completed in 26c5ca7 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvagg rvagg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rvagg @kylehuntsman