FIP-0076: Renumber the new methods to avoid collision with FIP-0070 #892
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
raulk and
jsoares
as code owners
jsoares
approved these changes
Dec 19, 2023
jennijuju
approved these changes
Jan 3, 2024
|
wait shouldnt the name be |
I think in the spec they're specified only as numbers, without additional zeros formatting. See: https://spec.filecoin.io/#example-storage-miner-actor Agree? |
Sorry I meant the revised method names are ProveCommitSectors_3_ & so. |
|
Chill, this PR was concurrent with #886. Now that that has merged, I have de-conflicted. |
|
Ah-ha, I knew I saw a PR with the right method number!! i thought I lost my mind for a sec haha |
jennijuju
approved these changes
Jan 4, 2024
|
green tick re-added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe this constitutes a substantive change to the FIP that should interrupt Last Call. The code in integration/direct-onboarding already reflects this after it was rebased against the FIP-0070 implementation.
CC @magik6k