Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian Stanford Question Answering Dataset #3

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

IronTony-Stark
Copy link
Collaborator

First thing first, I was not able to setup GoogleDrive as our source for downloading data. I may being dummy, but I just don't see a way to download a file without Auth0. Getting auth token is not that hard, but the real question is where to store it. I may need a deeper investigation on how python packages work and if they can contain secrets. I also tried to store our data in DropBox, but the problem is the same. So I ended up uploading it to GitHub repo :) We can later move it to some of our repos. The only thing is that such repository has to be public. Private would once again require auth token

P.S. And I'll probably need to refactor UaSquadDataset.parse sometime later

@IronTony-Stark IronTony-Stark self-assigned this Jun 2, 2021
Copy link
Member

@KyloRen1 KyloRen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I thought of creating JSON first and then uploading it somewhere

@KyloRen1 KyloRen1 requested a review from Smfun12 June 2, 2021 12:38
Copy link
Collaborator

@Smfun12 Smfun12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, unless two things:

  1. _check_exists method - I would rather rename it to file_exists, so the line if self._file_exists(): is more readable
  2. Why do you call self.parse(self.dataset_path), if parse is static(no need for self)?

@Smfun12 Smfun12 merged commit d5fc300 into main Jun 2, 2021
@IronTony-Stark IronTony-Stark deleted the UaSquadDataset branch June 2, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants