Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stanford Question Answering Dataset #2

Merged
merged 2 commits into from
May 1, 2021
Merged

Stanford Question Answering Dataset #2

merged 2 commits into from
May 1, 2021

Conversation

IronTony-Stark
Copy link
Collaborator

In the future we'll probably need to add logging or some kind of info messages to notify user that the dataset is loading, already exists etc

@KyloRen1
Copy link
Member

@IronTony-Stark , I guess context part is missing here

Copy link
Member

@KyloRen1 KyloRen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would also think about adding a progress bar on download or data loading methods

Copy link

@Anvilondre Anvilondre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KyloRen1 KyloRen1 merged commit e1201a5 into main May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants