Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support Right-to-Left scroll in Hebrew locale #280

Closed
sdavidliu opened this issue May 18, 2022 · 2 comments · Fixed by #281 or #289
Closed

[FEAT] Support Right-to-Left scroll in Hebrew locale #280

sdavidliu opened this issue May 18, 2022 · 2 comments · Fixed by #281 or #289
Labels
enhancement New feature or request

Comments

@sdavidliu
Copy link

Is your feature request related to a problem? Please describe.
After adding Hebrew to Supported Localization, I noticed that the scrolling will scroll in the opposite direction of where I am swiping. So if I try to swipe to the card on the left, it actually scrolls to the right. If I swipe to the card on the right, it scrolls to the left.
It's nice that it correctly places the items with the first item at the very right. 2nd item to its left. etc. However, the dragging animation is flipped around and may be counter-intuitive for users.

Describe the solution you'd like
Support scrolling in the correct direction for right-to-left locales.

Describe alternatives you've considered
N/A

Additional context
Screen Shot 2022-05-18 at 11 42 21 AM

@sdavidliu sdavidliu added the enhancement New feature or request label May 18, 2022
@fermoya fermoya linked a pull request May 20, 2022 that will close this issue
@fermoya
Copy link
Owner

fermoya commented May 20, 2022

should be done in 2.5.0-beta.1, do you mind giving me some feedback @sdavidliu please?

@sdavidliu
Copy link
Author

Hi @fermoya , thanks for the quick turnaround! It is mainly working as expected; however, on some of my swipes (especially when I reach the end) it still scrolls to the opposite direction. Not sure if it's happening when I scroll fast enough, but it seems a bit random. I attached a video in Arabic locale:

2.5.0-beta.1-arabic.mov.zip

@fermoya fermoya reopened this May 20, 2022
@fermoya fermoya linked a pull request Jul 20, 2022 that will close this issue
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants