Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C in Powershell and CMD profiles doesn't break current line, but does in WSL #91

Closed
ajruckman opened this issue Oct 6, 2018 · 6 comments · Fixed by #95
Closed
Labels
bug Something isn't working Fixed in next release This is already fixed and will be included in the next release
Milestone

Comments

@ajruckman
Copy link
Contributor

Normally in Powershell and Command Prompt terminals, pressing Ctrl+C breaks what you've typed on the current line and goes to a new line, but this only works in WSL tabs in Fluent Terminal.

What happens in powershell.exe: https://i.imgur.com/rBWlAls.png
What happens in WSL tabs in Fluent Terminal: https://i.imgur.com/Dh7VDtG.png
What happens in Powershell tabs in Fluent Terminal: https://i.imgur.com/5hDFY4U.png

Maybe the Copy keybinding is interfering..?

Also, I really love this project. I feel like this is the terminal Windows 10 should have had from the beginning. If you have a PayPal I would love to donate what I can :)

@felixse
Copy link
Owner

felixse commented Oct 7, 2018

Might by related to WinPTY, I expect this to become better once we support ConPTY. Does this cause any problem on your side? Copy keybinding should have no influence on this, it only listens for ctrl+c when something is selected

@ajruckman
Copy link
Contributor Author

Not sure what you are asking, does what cause a problem on my side?

maybe relevant: vercel/hyper#1121, microsoft/node-pty#216

@felixse
Copy link
Owner

felixse commented Oct 8, 2018

Does the inconsistent line breaking cause any issue for you? From my perspective this is just a bit odd, but nothing that breaks anything 😅

@ajruckman
Copy link
Contributor Author

I am very used to it, when I make a typo early in the line or realize I forgot to do something before what I started typing (like committing before pushing) I just do Ctrl+C and start over. And if it works in the native Windows terminals I think it should work here, right? The Hyper terminal issue I linked above is all about this so I think a lot of other people do it too: vercel/hyper#1121 (comment)

Here is a fix supposedly, to be released in WinPTY 0.4.4: rprichard/winpty@c9ce3ad

Since a new WinPTY version hasn't been released in over a year, maybe it would be worth it to just use the current code from master?

@ajruckman
Copy link
Contributor Author

I got it working by building winpty from master: https://i.imgur.com/dVJm2PB.png

@felixse felixse reopened this Oct 9, 2018
@felixse felixse added bug Something isn't working Fixed in next release This is already fixed and will be included in the next release labels Oct 9, 2018
@felixse felixse added this to the 0.2.1.0 milestone Oct 12, 2018
@felixse felixse closed this as completed Oct 12, 2018
@JokerQyou
Copy link

In the latest FluentTerminal (0.4.1.0) this is still an issue. Ctrl-C does not break the current line. But by turnning off this option, it starts working again in new terminal windows.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed in next release This is already fixed and will be included in the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants