Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity indicators on tabs #60

Closed
hanskokx opened this issue Jul 24, 2018 · 4 comments
Closed

Activity indicators on tabs #60

hanskokx opened this issue Jul 24, 2018 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@hanskokx
Copy link
Contributor

If I have multiple tabs open and there's activity in one of them, there needs to be some sort of a visual indicator on the tab itself. This could be in the form of a subtle highlight or a prepended bell icon, perhaps.

@felixse
Copy link
Owner

felixse commented Jul 24, 2018

Nice idea 👍

@felixse felixse added the enhancement New feature or request label Jul 24, 2018
@Riebart
Copy link
Contributor

Riebart commented Sep 28, 2018

With the new tab colour themes, we could indicate this by flashing between active and inactive background at some non-annoying rate. My gut tells me the bulk of the detection logic, or at least the detection event, is in

public void SubscribeForTerminalOutput(int terminalId, Action<string> callback)

@felixse
Copy link
Owner

felixse commented Sep 28, 2018

I thought about just adding a nice icon where the close button would be (since the tab colors PR only the active tab shows the close button to better emphasize which one is active), you think that might be enough?

Detecting should be no big problem, terminalOutput callback is definitevely the right place

@hanskokx
Copy link
Contributor Author

hanskokx commented Sep 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants