Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Ctrl+C to terminate batch job #151

Closed
aklein13 opened this issue Dec 16, 2018 · 3 comments
Closed

Double Ctrl+C to terminate batch job #151

aklein13 opened this issue Dec 16, 2018 · 3 comments
Labels
upstream This due to an external component we are using

Comments

@aklein13
Copy link

I was trying out Fluent Terminal and I run into an issue with Terminate batch job (Y/N) prompt after pressing Ctl+C.

In default PowerShell I could press Ctl+C twice to supress it instead of typing Y but it doesn't seem work in Fluent Terminal. Instead it adds ^C to the same line.

Example (yarn start -> Ctrl+C spam):
PowerShell: https://imgur.com/p4Mfqjy
Fluent Terminal: https://imgur.com/54siKmR

As an example I used yarn command but I got the same results with npm.

@felixse
Copy link
Owner

felixse commented Dec 17, 2018

Just checked this on my dev branch, this will be fixed by switching to ConPTY

@felixse felixse added the bug Something isn't working label Dec 17, 2018
@Jack-Works
Copy link

Yeah what about auto answer it likesother tools do? When "Terminate batch job" appears, automatically type "Y" then "Enter" to get rid of that.

@felixse felixse added upstream This due to an external component we are using and removed bug Something isn't working labels Feb 29, 2020
@felixse
Copy link
Owner

felixse commented Feb 29, 2020

upstream discussion: rprichard/winpty#116

Auto answering sounds like a hassle since it also needs to be localization aware. For German it needs to type 'j' instead of 'y' for example.

I'm closing this now since it's working in ConPty (default for powershell profiles)

@felixse felixse closed this as completed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream This due to an external component we are using
Projects
None yet
Development

No branches or pull requests

3 participants