Use jll to install native lib #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 87.92% 87.91% -0.02%
==========================================
Files 11 11
Lines 1077 1076 -1
==========================================
- Hits 947 946 -1
Misses 130 130
Continue to review full report at Codecov.
|
|
This is awesome! Thanks, @aviks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiled the mongo-c-driver libs without SASL, which means it won't be able to do krb5 or SASL auth mechanisms. Other auth mechanisms should work, but unsure how to test it fully.
Also, I don't have a local install of mongodb, so haven't been able to run all tests. Let's see what travis says.