Remove cross-fetch dependency. #1
Conversation
|
@fboucquez: do you have time and interest to review the odd PR to rosetta-client-typescript and rosetta-explorer? |
|
Hey @dvc94ch , sorry for the late response. I'm interested just a bit busy atm. Please bear with me but keep them coming :) |
| @@ -13,7 +13,6 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| import fetch from 'cross-fetch'; | |||
There was a problem hiding this comment.
Would this work on browser and node environments? Is fetch out of the box for node js 18+?
There was a problem hiding this comment.
exactly. so the browsers got support for the fetch api and then someone wrote the cross-fetch polyfill, and now node js 18+ supports the api out of the box.
There was a problem hiding this comment.
there is more information in the release announcement about this:
There was a problem hiding this comment.
Awesome, reading https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API#browser_compatibility and other posts
There was a problem hiding this comment.
People using old node version could provide a custom fetch implementation
|
so wdyt? can this be merged and a new release made? |
|
@dvc94ch , release, Please try version 1.4.13-alpha-c6861d7. It includes the latest openapi spec |
No longer required since nodejs 18 implements the fetch api. Because of this
cross-fetchis no longer maintained [0], andnode-fetchwas giving me some weird "socket hangup" error which is resolved by relying on the nodejs 18 fetch.node-fetch-cjs? lquixada/cross-fetch#146