Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite code using Go 1.23 iterators #911

Merged
merged 8 commits into from
Aug 31, 2024
Merged

refactor: rewrite code using Go 1.23 iterators #911

merged 8 commits into from
Aug 31, 2024

Conversation

favonia
Copy link
Owner

@favonia favonia commented Aug 30, 2024

No description provided.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 95.58%. Comparing base (11d9705) to head (d81599d).

Files with missing lines Patch % Lines
cmd/ddns/ddns.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   95.59%   95.58%   -0.02%     
==========================================
  Files          61       58       -3     
  Lines        2588     2581       -7     
==========================================
- Hits         2474     2467       -7     
  Misses        104      104              
  Partials       10       10              
Flag Coverage Δ
unittests 95.58% <91.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia force-pushed the iter branch 5 times, most recently from d449a86 to 11f6ab5 Compare August 31, 2024 00:52
@favonia favonia marked this pull request as ready for review August 31, 2024 01:29
@favonia favonia changed the title refactor: rewrite code using Go 1.23 iterators refactor: rewrite some code using Go 1.23 iterators Aug 31, 2024
@favonia favonia changed the title refactor: rewrite some code using Go 1.23 iterators refactor: rewrite code using Go 1.23 iterators Aug 31, 2024
@favonia favonia enabled auto-merge (squash) August 31, 2024 01:32
@favonia favonia merged commit 319e6a0 into main Aug 31, 2024
8 of 10 checks passed
@favonia favonia deleted the iter branch August 31, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant