-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): update WAF lists #797
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
=======================================
Coverage ? 94.71%
=======================================
Files ? 58
Lines ? 2573
Branches ? 0
=======================================
Hits ? 2437
Misses ? 123
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0e997a9
to
5fe86fb
Compare
f93c439
to
c567a9a
Compare
@WolfRamAlpha12 @jdvuyk @Gamerou I am happy to report that the code in this PR is working (updating my personal list as expected)! But I still need to write good messages, test cases, and documentation. Some design questions for you:
|
Hi, Great to hear that the code is working as expected! Here are my thoughts on your design questions:
Please let me know if you need further input or assistance! And again: Thank you very much for doing this for us! |
@Gamerou Thank you. About the (wide) IP ranges and their order, I have a follow-up question. Suppose the current list is
and the detected IP is 10.0.0.1. Do you want to keep all items starting with "10" in their current order (but remove the two entries starting with "99")? That is, should the new list be
|
77d877d
to
740cc0f
Compare
The current testing misses 4 lines of code and the documentation has not started, but this PR is dragging for too long... let's merge it! |
Close #646. Close #684.
Progress
api
setter
updater
config
README
UI
WAF_LISTS=list1,list2
WAF_LIST_DESCRIPTION=blah blah blah
Design issues
DELETE_ON_STOP=1
? YES