Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setter): quote DNS record IDs to prevent injection attacks #502

Merged
merged 1 commit into from
May 25, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented May 25, 2023

Closes #496.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #502 (1b54ee6) into main (e87cc52) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #502   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files          44       44           
  Lines        2262     2262           
=======================================
  Hits         1992     1992           
  Misses        260      260           
  Partials       10       10           
Flag Coverage Δ
unittests 88.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/setter/setter.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia merged commit d978c68 into main May 25, 2023
@favonia favonia deleted the quote-cloudflare-record-ids branch May 25, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quote everything from Cloudflare
1 participant