Set $id after clone

[Eomm]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the issue has not already been raised

Issue

Given an origin flunet-json-schema object filtered with only/without it is not possible to set the BaseSchema's $id:

const WhizBang = fluent
  .object()
  .additionalProperties(false)
  .id('whizbang')
  .title('WhizBang')
  .prop(
    'whiz'
  , fluent.string().required().minLength(1)
  )
  .prop(
    'bang'
  , fluent.string().required().minLength(1)
  )

const part = WhizBang.only(['whiz'])
console.log(JSON.stringify(part.id('asd').valueOf(), null, 2))

Shows:

{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "additionalProperties": false,
  "$id": "whizbang",
  "title": "WhizBang",
  "properties": {
    "whiz": {
+      "$id": "asd",
      "type": "string",
      "minLength": 1
    }
  },
  "required": [
    "whiz"
  ]
}

I can't find a way to set the "$id": "whizbang" field.

Ref fastify/fastify#4276

[zrosenbauer]

@Eomm instead of resetting the ID would it make sense to just omit it? I'm not sure it should even reference the $id at this point...

.only & .without are state mutations that invalidate the ref aka should compose new objects not mutate the old?

[esatterwhite]

It would need to be both. It would need to omit the id by default, and allow you to set it in the correct location of the schema

[zrosenbauer]

I'm happy to open up a PR handling both if @Eomm or other core folks thinks it make sense.

[Eomm]

Yes, I agree:

• remove it by default
• allow to set it again by calling .id()

Note that this would be a breaking change

[zrosenbauer]

Ok cool, I'm gonna take a stab this weekend or if I get some time after hours. 🚀

[esatterwhite]

The problem is rooted in the use of setAttribute of BaseSchema

fluent-json-schema/src/utils.js

Lines 188 to 195 in 490c24d

	const currentProp = last(schema.properties)
	if (currentProp) {
	const { name, ...props } = currentProp
	return options.factory({ schema, ...options }).prop(name, {
	[key]: value,
	...props,
	})
	}

Once an object has properties, all things are added to its properties rather than the root of the schema. this doesn't seem too hard to fix

[aboutlo]

resolved by #195