Allowing custom error messaging on unsupported encoding #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request fastify#86 from j-windsor/master
Co-Authored-By: Denis Fäcke <serayaeryn@gmail.com>
delvedor
reviewed
Oct 29, 2019
j-windsor
commented
Oct 29, 2019
niktekusho
reviewed
Oct 31, 2019
Co-Authored-By: Nicola Dal Maso <niktekusho@users.noreply.github.com>
Eomm
approved these changes
Oct 31, 2019
|
I feel good about getting this merged now! |
Eomm
requested changes
Nov 1, 2019
mcollina
requested changes
Nov 4, 2019
Eomm
approved these changes
Nov 14, 2019
mcollina
approved these changes
Nov 15, 2019
Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>
Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>
delvedor
reviewed
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created new function in the options to allow users to specify a custom response when the encoding is unsupported.
I could not follow the original design of using the reply.send() function in the callback because you can't call that function in the onSend hook.
Checklist
npm run testandnpm run benchmark