Support asterisk in accept-encoding header #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvedor
reviewed
Nov 20, 2017
| @@ -155,6 +155,9 @@ function getEncodingHeader (request) { | |||
| if (supportedEncodings.indexOf(acceptEncodings[i]) > -1) { | |||
| return acceptEncodings[i] | |||
| } | |||
| if (acceptEncodings[i].indexOf('*') > -1) { | |||
There was a problem hiding this comment.
I think this can be faster.
If a user puts * as accepted encodings, there will not be other stuff there.
if so, we can just check it the header value is equal to *.
Does it make sense?
There was a problem hiding this comment.
No, we cannot do that. Something like 'gzip;q=1.0, *;q=0.5' is valid and might occur. This would mean use gzip if possible and else use any other encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for an asterisk
*in theaccept-encodingheader.