Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use node: prefix for builtins #270

Merged
merged 2 commits into from
Sep 8, 2023
Merged

perf: use node: prefix for builtins #270

merged 2 commits into from
Sep 8, 2023

Conversation

gurgunday
Copy link
Member

Same as fastify/fastify-static#407

Checklist

@gurgunday gurgunday changed the title use node: prefix chore: use node: prefix for builtins Sep 8, 2023
@Fdawgs Fdawgs changed the title chore: use node: prefix for builtins perf: use node: prefix for builtins Sep 8, 2023
Fdawgs
Fdawgs requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See fastify/fastify-cookie#250 (review)

@gurgunday
Copy link
Member Author

@Fdawgs done

@gurgunday gurgunday merged commit 35c2639 into fastify:master Sep 8, 2023
15 checks passed
@gurgunday gurgunday deleted the node-prefix branch September 8, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurgunday @Fdawgs