Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 upgrade #107

Merged
merged 7 commits into from
Apr 28, 2020
Merged

V3 upgrade #107

merged 7 commits into from
Apr 28, 2020

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Apr 23, 2020 •
edited
Loading

fastify/fastify#2217

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@thomheymann thomheymann mentioned this pull request Apr 23, 2020
Closed
51 tasks
jsumners
jsumners reviewed Apr 23, 2020
View reviewed changes
package.json Show resolved Hide resolved
mcollina
mcollina reviewed Apr 23, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
mcollina
mcollina approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.js Outdated Show resolved Hide resolved
@mcollina mcollina merged commit f6fed1c into fastify:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomheymann @mcollina @jsumners