Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Align to gym>=0.26 API #98

Open
epignatelli opened this issue Jan 15, 2024 · 3 comments · May be fixed by #99
Open

[FEATURE] Align to gym>=0.26 API #98

epignatelli opened this issue Jan 15, 2024 · 3 comments · May be fixed by #99
Labels
enhancement New feature or request

Comments

@epignatelli
Copy link

epignatelli commented Jan 15, 2024 •
edited
Loading

🚀 Feature

MiniHack currently implements thegym<0.26API, which is deprecated.

Motivation

Aligning to gym>=0.26 has some ready-baked benefits, for example:

import gym.vector
import minihack

num_envs = 16
env = gym.vector.make("MiniHack-KeyRoom-Fixed-S5-v0", num_envs=num_envs)

and a step forward for gymnasium compat as well.

Pitch

The required steps are in the official migration guide:
https://gymnasium.farama.org/content/migration-guide/

Alternatives

Additional context
@epignatelli epignatelli added the enhancement New feature or request label Jan 15, 2024
@epignatelli epignatelli linked a pull request Jan 15, 2024 that will close this issue
Draft
7 tasks
@jbial
Copy link

jbial commented Apr 18, 2024

Any updates on this? I see that the PR passed the checks - any reason for the delay? This would be a great enhancement.

@epignatelli
Copy link
Author

epignatelli commented Apr 19, 2024 •
edited
Loading

Hey @jbial, I'll let maintainers chip in, but this is waiting for the same set changes in the NLE, and I don't think it will be merged anytime before that happens. See facebookresearch/nle#357 to track the issue in NLE.

If you need the 0.26 gym interface, you can use the fork for the moment, I'll do my best to keep it synched.

@LukasFehring
Copy link

Hey @jbial, @epignatelli,
The branch you mentioned was merged two weeks ago, seemingly instantly after you mentioned the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align to gym>0.26 interface epignatelli/minihack
3 participants
@epignatelli @jbial @LukasFehring