Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added polymetis usage example #897

Merged

Conversation

laikhtewari
Copy link
Contributor

@laikhtewari laikhtewari commented Jul 6, 2022

Motivation and Context

A jupyter notebook demonstrating how to use habitat with a custom controller through polymetis was created.
T122948275

How Has This Been Tested

Running the Jupyter notebook with the correct environment setup shows a waving robot in a specified scene (franka arm in an apartment with defaults)

Note that the following were added to the polymetis conda environment:
- opencv=4.5.1
- jupyter

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 6, 2022
@laikhtewari laikhtewari marked this pull request as ready for review July 7, 2022 14:27
@Skylion007
Copy link
Contributor

@laikhtewari Can you look into try to make this a colab notebook? See the ones defined in the examples folder for comparison.

@aclegg3
Copy link
Contributor

aclegg3 commented Jul 12, 2022

@laikhtewari Can you look into try to make this a colab notebook? See the ones defined in the examples folder for comparison.

Agreed. We also have automation tools in place to automatically convert to a python script on commit which can be run locally and during CI testing.
Just place the colab notebook in examples/tutorials/nb_python/

@dhruvbatra
Copy link
Contributor

Agreed. Once it's in that state, we can also add your tutorial to our current set of tutorials: https://aihabitat.org/tutorial/

@1heart
Copy link
Contributor

1heart commented Jul 20, 2022

From Alex's comment over chat:

Thanks for trying.
If Colab as a platform is prohibitive here then we can leave it in Jupyter. Let's add a note about why in the text of the notebook.
In that case you can leave it in tutorials, but maybe not in the colab subdirectories (those are explicitly scanned and converted to python).

We can file an Issue for converting to Colab another time. Let's try to merge this soon.

@laikhtewari
Copy link
Contributor Author

Added issue to convert notebook into colab: #910

@laikhtewari laikhtewari merged commit 4ad8cd8 into facebookresearch:main Jul 22, 2022
@laikhtewari laikhtewari deleted the laikh/polymetis_example branch July 22, 2022 20:58
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* added polymetis usage example

* change execution count to null

* Moving notebook to examples folder

* precommit to generate py script from colab

* updated pre commit config

* moved notebook outside of colabs
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
* added polymetis usage example

* change execution count to null

* Moving notebook to examples folder

* precommit to generate py script from colab

* updated pre commit config

* moved notebook outside of colabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants