Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bugfix): Fix mypy typing error + precommit issue #865

Merged
merged 2 commits into from
May 4, 2022
Merged

(bugfix): Fix mypy typing error + precommit issue #865

merged 2 commits into from
May 4, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 4, 2022
@Skylion007 Skylion007 changed the title (bugfix): Fix mypy typing error + precommit master issue (bugfix): Fix mypy typing error + precommit issue May 4, 2022
@Skylion007 Skylion007 merged commit 1d187db into main May 4, 2022
@Skylion007 Skylion007 deleted the fix-typing-hints branch May 4, 2022 20:11
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@Skylion007
(bugfix): Fix mypy typing error + precommit issue (facebookresearch#865)
ddadf2e 
* Fix mypy typing error

* Fix pre-commit issue
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@Skylion007
(bugfix): Fix mypy typing error + precommit issue (facebookresearch#865)
fead766 
* Fix mypy typing error

* Fix pre-commit issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentpierre vincentpierre vincentpierre approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @vincentpierre @facebook-github-bot