Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slambased install script update #552

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Conversation

Jbwasse2
Copy link
Contributor

Motivation and Context

The url to get eigen3 in the old script no longer works, I think I found the new link. I also fixed a bug with the CONDA_DIR variable not getting at the end.

NA

How Has This Been Tested

Ran on local machine, everything seems to have been installed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 28, 2020
@Skylion007
Copy link
Contributor

LGTM, let's get this merged.

@Skylion007 Skylion007 merged commit 38dd4d2 into facebookresearch:master Dec 28, 2020
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* updating install script

* forgot to uncomment a line
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
* updating install script

* forgot to uncomment a line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants