Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 + Bugfixes + Linter #459

Merged
merged 29 commits into from
Aug 22, 2020
Merged

Flake8 + Bugfixes + Linter #459

merged 29 commits into from
Aug 22, 2020

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • This will do static code analysis on Habitat-Lab just like it soon will on Habitat-Sim

How Has This Been Tested

  • I flake8'd the whole repo and made precommit hooks

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@Skylion007 Skylion007 requested review from mathfac and abhiskk and removed request for mathfac August 21, 2020 20:39
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #459 into master will decrease coverage by 0.01%.
The diff coverage is 80.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   77.69%   77.67%   -0.02%     
==========================================
  Files         110      110              
  Lines        8549     8497      -52     
==========================================
- Hits         6642     6600      -42     
+ Misses       1907     1897      -10     
Impacted Files Coverage Δ
examples/vln_benchmark.py 0.00% <0.00%> (ø)
habitat/core/benchmark.py 47.94% <0.00%> (ø)
habitat/core/embodied_task.py 90.62% <0.00%> (ø)
...abitat/sims/habitat_simulator/habitat_simulator.py 94.39% <ø> (-0.03%) ⬇️
habitat/sims/pyrobot/pyrobot.py 84.48% <ø> (-0.14%) ⬇️
habitat/utils/__init__.py 100.00% <ø> (ø)
habitat_baselines/agents/ppo_agents.py 77.46% <ø> (+0.75%) ⬆️
habitat_baselines/agents/slam_agents.py 0.00% <0.00%> (ø)
habitat_baselines/common/env_utils.py 87.50% <ø> (-0.31%) ⬇️
habitat_baselines/rl/ddppo/policy/resnet.py 68.64% <ø> (-0.27%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3d1a9...51dd96b. Read the comment docs.

@Skylion007 Skylion007 merged commit 358969e into master Aug 22, 2020
@Skylion007 Skylion007 deleted the flake8 branch August 22, 2020 21:52
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Ran autoflake

* flake8 examples

* flake8 habitat

* Flake8 Habitat_baselines

* flake8 tests

* Add flake8 linter

* Fix eqa __init__

* Fix vln datasets.py

* fix nav __init__

* Fix .circleci linter

* Fix EQA __init__.py

* Re-enable pre-commit hook

* Refix vln

* More __init__ repair

* Fix two inits

* Fix typo

* Finalize __init__s and tests fixes

* Update deprecated isort pre-commit hook

* Add missing auotflake flag

* clean up errors on pyrobot import

* Apparently seed-isort pre-commit is deprecated

* More bugfixes

* reuse __init__ in vocabdict and fix m_docstring

* Fix typo

* Fix typo

* Address comments

* Add back known_first_party

* Fix isort tutorial
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
* Ran autoflake

* flake8 examples

* flake8 habitat

* Flake8 Habitat_baselines

* flake8 tests

* Add flake8 linter

* Fix eqa __init__

* Fix vln datasets.py

* fix nav __init__

* Fix .circleci linter

* Fix EQA __init__.py

* Re-enable pre-commit hook

* Refix vln

* More __init__ repair

* Fix two inits

* Fix typo

* Finalize __init__s and tests fixes

* Update deprecated isort pre-commit hook

* Add missing auotflake flag

* clean up errors on pyrobot import

* Apparently seed-isort pre-commit is deprecated

* More bugfixes

* reuse __init__ in vocabdict and fix m_docstring

* Fix typo

* Fix typo

* Address comments

* Add back known_first_party

* Fix isort tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants