Gibson large generation #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Adding this to examples did not seem like a good idea, but I could not think of any other places for adding the script. Please let me know if there's a better organization for this. |
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 76.32% 76.32%
=======================================
Files 108 108
Lines 7640 7640
=======================================
Hits 5831 5831
Misses 1809 1809 Continue to review full report at Codecov.
|
erikwijmans
reviewed
May 7, 2020
| generate_pointnav_episode, | ||
| ) | ||
|
|
||
| num_episodes_per_scene = int(1e2) |
There was a problem hiding this comment.
Suggested change
| num_episodes_per_scene = int(1e2) | |
| num_episodes_per_scene = int(1e4) |
Should probably generate more episodes by default.
dhruvbatra
pushed a commit
that referenced
this pull request
May 10, 2020
- Use jest-image-snapshot to generate and compare snapshots - Use puppeteer to launch chromium browser in headless mode - Use finalhandler and static-serve to finalize requests and serve static content easily - Update package.json with required packages
erikwijmans
approved these changes
May 11, 2020
|
|
||
| # Load train / val statistics | ||
| dataset_statistics = json.load( | ||
| open("./examples/gibson_large_generation/gibson_dset_with_qual.json") |
There was a problem hiding this comment.
Suggested change
| open("./examples/gibson_large_generation/gibson_dset_with_qual.json") | |
| open(osp.join(osp.dirname(__file__), "gibson_dset_with_qual.json"), "r") |
mathfac
reviewed
May 18, 2020
| @@ -0,0 +1,87 @@ | |||
| """This script is used to generate customized Gibson training splits for the | |||
There was a problem hiding this comment.
We need to add header:
more
#!/usr/bin/env python3
# Copyright (c) Facebook, Inc. and its affiliates.
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
mathfac
reviewed
May 18, 2020
| generate_pointnav_episode, | ||
| ) | ||
|
|
||
| num_episodes_per_scene = int(1e4) |
There was a problem hiding this comment.
Const are upper case per code guidelines:
Suggested change
| num_episodes_per_scene = int(1e4) | |
| NUM_EPISODES_PER_SCENE = int(1e4) |
mathfac
reviewed
May 18, 2020
|
|
||
| path = "./data/datasets/pointnav/gibson/v2/train_large/train_large.json.gz" | ||
| with gzip.open(path, "wt") as f: | ||
| json.dump(dict(episodes=[]), f) |
There was a problem hiding this comment.
gibson_dset_with_qual.json should be mentioned in License part of readme as Gibson based task datasets and trained models => Gibson based task datasets and code generating it, trained models
mathfac
requested changes
May 18, 2020
habitat_baselines/rl/ddppo/data_generation/create_gibson_large_dataset.py
Outdated
Show resolved
Hide resolved
dhruvbatra
reviewed
May 19, 2020
dhruvbatra
approved these changes
May 19, 2020
Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com>
erikwijmans
approved these changes
Jun 8, 2020
|
Apologies for the slowness on landing this! |
|
Thank you for the contribution! |
|
Glad to be of help! |
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* added gibson large generation script * ran black for formatting * updated number of episodes, moved to ddppo directory * updated license to include data generation * added header * changed const to upper case * added separate function call * Update README.md Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com> Co-authored-by: Santhosh K. Ramakrishnan <sramarki@fb.com> Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com>
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* added gibson large generation script * ran black for formatting * updated number of episodes, moved to ddppo directory * updated license to include data generation * added header * changed const to upper case * added separate function call * Update README.md Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com> Co-authored-by: Santhosh K. Ramakrishnan <sramarki@fb.com> Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds a script to generate customized Gibson training datasets for the PointNav task. Specifically, the Gibson-2+ and Gibson-0+ training splits used in the DD-PPO paper (https://arxiv.org/abs/1911.00357) can be generated by setting the appropriate quality threshold.
How Has This Been Tested
Tested bug-free execution and the resulting data splits.
Types of changes
Checklist