Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] use PyTorch Sphinx theme #75

Merged
merged 1 commit into from
Sep 10, 2020
Merged

[docs] use PyTorch Sphinx theme #75

merged 1 commit into from
Sep 10, 2020

Conversation

msbaines
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2020
min-xu-ai
min-xu-ai approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@min-xu-ai min-xu-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, ship it!

@msbaines msbaines merged commit ebbd5f6 into master Sep 10, 2020
myleott added a commit that referenced this pull request Feb 22, 2021
@myleott
Add all_gather stream and disable reshard_after_forward on root insta…
74b0223 
…nce (#75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@min-xu-ai min-xu-ai min-xu-ai approved these changes

@froody froody Awaiting requested review from froody

@blefaudeux blefaudeux Awaiting requested review from blefaudeux

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbaines @min-xu-ai @facebook-github-bot