Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] fix typo in requirements.txt #73

Merged
merged 1 commit into from
Sep 9, 2020
Merged

[fix] fix typo in requirements.txt #73

merged 1 commit into from
Sep 9, 2020

Conversation

msbaines
Copy link
Contributor

@msbaines msbaines commented Sep 9, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@msbaines msbaines merged commit 5b75dd3 into master Sep 9, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2020
min-xu-ai
min-xu-ai reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@min-xu-ai min-xu-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that too.

myleott added a commit that referenced this pull request Feb 22, 2021
@myleott
Refactor param init and streams logic (#73)
0ca378b 
- Add two new tests (TestParamInit and TestSerialization) which would have failed previously. These mostly cover the fairseq usage that was not captured by tests before.
- Deprecate the `compute_device` option, since we don't actually use it anywhere (nor do we need it in fairseq)
- Remove `_move_fp32_shard_to_cuda` and embrace a stronger invariant: p.data and p._fp32_shard should always be the same at the start and end of each function (namely, state_dict, and also forward/backward).
- Slightly unrelated, but refactor streams logic a bit, so we have a single `self._streams` dictionary -- this will make an upcoming PR that adds more streams easier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@min-xu-ai min-xu-ai min-xu-ai left review comments

@froody froody Awaiting requested review from froody

@blefaudeux blefaudeux Awaiting requested review from blefaudeux

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbaines @min-xu-ai @facebook-github-bot